Skip to content
Snippets Groups Projects
Commit b815e4df authored by Alexis GAMELIN's avatar Alexis GAMELIN
Browse files

[Fix] Sign of long wake in LongRangeResistiveWall

Fix wrong sign of the longitudinal wake in LongRangeResistiveWall, thanks to Keon Hee Kim for pointing this out.
Fix ImpedanceModel.add method to raise error before making modifications.
parent ca01ff54
No related branches found
No related tags found
No related merge requests found
...@@ -102,8 +102,6 @@ class ImpedanceModel(): ...@@ -102,8 +102,6 @@ class ImpedanceModel():
None. None.
""" """
self.wakefields.append(wakefield)
self.positions.append(positions)
if name is None: if name is None:
name = wakefield.name name = wakefield.name
if name is None: if name is None:
...@@ -112,6 +110,8 @@ class ImpedanceModel(): ...@@ -112,6 +110,8 @@ class ImpedanceModel():
self.names.append(name) self.names.append(name)
else: else:
raise ValueError("This name is already taken.") raise ValueError("This name is already taken.")
self.wakefields.append(wakefield)
self.positions.append(positions)
def add_global(self, wakefield, name=None): def add_global(self, wakefield, name=None):
""" """
......
...@@ -793,7 +793,7 @@ class LongRangeResistiveWall(Element): ...@@ -793,7 +793,7 @@ class LongRangeResistiveWall(Element):
for wake_type in self.types: for wake_type in self.types:
kick = self.get_kick(rank, wake_type) kick = self.get_kick(rank, wake_type)
if wake_type == "Wlong": if wake_type == "Wlong":
bunch["delta"] += kick / self.ring.E0 bunch["delta"] -= kick / self.ring.E0
elif wake_type == "Wxdip": elif wake_type == "Wxdip":
bunch["xp"] += kick / self.ring.E0 bunch["xp"] += kick / self.ring.E0
elif wake_type == "Wydip": elif wake_type == "Wydip":
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment