Faster CircularResistiveWall

Update CircularResistiveWall class in resistive_wall.py to replace numerical integrations with an analytical forms for improved performance.

• Numerical integrations are removed.
• LongWakeExact and TransWakeExact are used even in the case where time > 20*t0.
• "atol" for LongWakeExact is removed.

I believe "atol" is not needed when considering the fundamental theorem of beam loading. This is because Wl(0) = Wl(0+)/2 is comes from the equation Wl(0) = [Wl(0-)*l/2 + Wl(0+)*l/2] / l, which represents the average Wl value of a very narrow bin (as the length of bin l -> 0) at the origin. Defining "atol" for the fundamental theorem of beam loading introduces the possibility that more than one point could be divided by 2, which I believe is mathematically and physically unacceptable. Thus, it is correct to consider the fundamental theorem of beam loading only at the origin. PyHEADTAIL also considers the fundamental theorem of beam loading only at the origin. Please see def function_longitudinal at the link (line 341).

mbtrack2/impedance/resistive_wall.py

@@ -171,11 +171,17 @@ class CircularResistiveWall(WakeField):
         if exact == True:
             idx2 = time == 0
             idx3 = np.logical_not(np.logical_or(idx1, idx2))
-            idx4 = np.isclose(0, time, atol=atol)
+            # idx4 = np.isclose(time, 0, atol=atol) & (time >= 0)
             factor = self.Z0 * c / (3 * np.pi * self.radius**2) * self.length
-            wl[idx2] = 3 * factor
+            if np.any(idx2):
+                # fundamental theorem of beam loading
+                wl[idx2] = 3 * factor / 2
             wl[idx3] = self.__LongWakeExact(time[idx3], factor)
-            wl[idx4] *= 0.5
+            # if np.any(idx4):
+            #     closest_to_zero_idx = np.argmin(time[idx4])
+            #     # Get the actual index in the original array
+            #     closest_to_zero_idx = np.where(idx4)[0][closest_to_zero_idx]
+            #     wl[closest_to_zero_idx] *= 0.5
         else:
             idx2 = np.logical_not(idx1)
             wl[idx2] = self.__LongWakeApprox(time[idx2])
@@ -249,13 +255,13 @@ class CircularResistiveWall(WakeField):
 
     def __LongWakeApprox(self, t):
         wl = -1 * (1 / (4 * np.pi * self.radius) *
-            np.sqrt(self.Z0 * self.rho / (c * np.pi)) /
-            t**(3 / 2)) * self.length
+            np.sqrt(self.Z0 * self.rho / (c * np.pi * t**3))
+            * self.length)
         return wl
 
     def __TransWakeApprox(self, t):
         wt = (1 / (np.pi * self.radius**3) *
-            np.sqrt(self.Z0 * c * self.rho / np.pi) / t**(1 / 2) *
+            np.sqrt(self.Z0 * c * self.rho / (np.pi * t)) *
             self.length)
         return wt