Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
H
HdbTdbArchivingServers
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Software Control System
Tango controls archiving
HdbTdbArchivingServers
Commits
84ee9140
Commit
84ee9140
authored
Nov 16, 2015
by
Raphael GIRARDOT
Browse files
Options
Downloads
Patches
Plain Diff
Retry for KO attributes done by watcher should work now (
TANGOARCH-497
)
parent
ccb917b3
No related branches found
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/main/java/Common/Archiver/Collector/ArchiverCollector.java
+3
-32
3 additions, 32 deletions
...ain/java/Common/Archiver/Collector/ArchiverCollector.java
src/main/java/HdbArchiver/Collector/HdbCollector.java
+3
-1
3 additions, 1 deletion
src/main/java/HdbArchiver/Collector/HdbCollector.java
with
6 additions
and
33 deletions
src/main/java/Common/Archiver/Collector/ArchiverCollector.java
+
3
−
32
View file @
84ee9140
package
Common.Archiver.Collector
;
import
java.io.PrintWriter
;
import
java.io.StringWriter
;
import
java.text.SimpleDateFormat
;
import
java.util.ArrayList
;
import
java.util.Arrays
;
...
...
@@ -12,15 +10,14 @@ import java.util.Map;
import
java.util.concurrent.ConcurrentHashMap
;
import
org.slf4j.Logger
;
import
org.tango.utils.DevFailedUtils
;
import
fr.esrf.Tango.DevFailed
;
import
fr.esrf.TangoDs.Util
;
import
fr.esrf.tangoatk.core.AttributePolledList
;
import
fr.esrf.tangoatk.core.ErrorEvent
;
import
fr.esrf.tangoatk.core.IAttribute
;
import
fr.esrf.tangoatk.core.IErrorListener
;
import
fr.soleil.archiving.common.api.tools.ArchivingEvent
;
import
fr.soleil.archiving.hdbtdb.api.tools.DBTools
;
import
fr.soleil.archiving.hdbtdb.api.tools.ScalarEvent
;
public
abstract
class
ArchiverCollector
implements
IErrorListener
{
...
...
@@ -287,7 +284,7 @@ public abstract class ArchiverCollector implements IErrorListener {
Throwable
error
=
errorEvent
.
getError
();
if
(
error
!=
null
)
{
builder
.
append
(
"\n\tReason: "
);
appendErrorToStringBuilder
(
builder
,
error
);
DBTools
.
appendErrorToStringBuilder
(
builder
,
error
);
}
String
errorMess
=
builder
.
toString
();
logger
.
error
(
errorMess
);
...
...
@@ -304,7 +301,7 @@ public abstract class ArchiverCollector implements IErrorListener {
}
protected
void
registerErrorMessage
(
String
name
,
Throwable
error
)
{
registerErrorMessage
(
name
,
appendErrorToStringBuilder
(
new
StringBuilder
(),
error
).
toString
());
registerErrorMessage
(
name
,
DBTools
.
appendErrorToStringBuilder
(
new
StringBuilder
(),
error
).
toString
());
}
protected
void
removeErrorMessage
(
String
name
)
{
...
...
@@ -323,30 +320,4 @@ public abstract class ArchiverCollector implements IErrorListener {
return
result
;
}
/**
* Appends the stack trace of a {@link Throwable} to a {@link StringBuilder}. If the {@link Throwable} is a
* {@link DevFailed}, this method will append the result of {@link DevFailedUtils#toString(DevFailed)} to the
* {@link StringBuilder} instead of the stack trace.
*
* @param builder The {@link StringBuilder} to which to append the stack trace. If <code>null</code>, a new one will
* be created.
* @param error The {@link Throwable} of which the stack trace must be extracted.
* @return A {@link StringBuilder}, never <code>null</code>.
*/
public
static
StringBuilder
appendErrorToStringBuilder
(
StringBuilder
builder
,
Throwable
error
)
{
if
(
builder
==
null
)
{
builder
=
new
StringBuilder
();
}
if
(
error
!=
null
)
{
if
(
error
instanceof
DevFailed
)
{
builder
.
append
(
DevFailedUtils
.
toString
((
DevFailed
)
error
));
}
else
{
StringWriter
errors
=
new
StringWriter
();
error
.
printStackTrace
(
new
PrintWriter
(
errors
));
builder
.
append
(
errors
.
toString
());
}
}
return
builder
;
}
}
This diff is collapsed.
Click to expand it.
src/main/java/HdbArchiver/Collector/HdbCollector.java
+
3
−
1
View file @
84ee9140
...
...
@@ -132,6 +132,7 @@ import HdbArchiver.HdbArchiver;
import
fr.soleil.archiving.common.api.exception.ArchivingException
;
import
fr.soleil.archiving.common.api.tools.ArchivingEvent
;
import
fr.soleil.archiving.hdbtdb.api.tools.AttributeLightMode
;
import
fr.soleil.archiving.hdbtdb.api.tools.DBTools
;
import
fr.soleil.archiving.hdbtdb.api.tools.LimitedStack
;
public
abstract
class
HdbCollector
extends
ArchiverCollector
{
...
...
@@ -219,7 +220,8 @@ public abstract class HdbCollector extends ArchiverCollector {
if
(
e
instanceof
ArchivingException
)
{
throw
(
ArchivingException
)
e
;
}
else
{
ArchivingException
exception
=
new
ArchivingException
(
appendErrorToStringBuilder
(
null
,
e
).
toString
());
ArchivingException
exception
=
new
ArchivingException
(
DBTools
.
appendErrorToStringBuilder
(
null
,
e
)
.
toString
());
throw
exception
;
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment