Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
A
ArchiveExtractor
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
DG
ArchiveExtractor
Commits
a3c1f5d6
Commit
a3c1f5d6
authored
2 years ago
by
BRONES Romain
Browse files
Options
Downloads
Patches
Plain Diff
Fix retry exception for Device command extract
* The previous code did not handle the retry correctly
parent
c7036db2
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
core/ArchiveExtractor.py
+4
-4
4 additions, 4 deletions
core/ArchiveExtractor.py
with
4 additions
and
4 deletions
core/ArchiveExtractor.py
+
4
−
4
View file @
a3c1f5d6
...
...
@@ -447,7 +447,7 @@ class ArchiveExtractor:
None if failed after the amount of retries.
"""
for
i
in
range
(
retry
-
1
):
for
i
in
range
(
retry
):
# Make retrieval request
self
.
logger
.
debug
(
"
Execute %s (%s)
"
%
(
cmd
,
arg
))
try
:
...
...
@@ -455,12 +455,12 @@ class ArchiveExtractor:
except
tango
.
DevFailed
as
e
:
self
.
logger
.
warning
(
"
The extractor device returned the following error:
"
)
self
.
logger
.
warning
(
e
)
if
i
==
retry
-
1
:
logger
.
error
(
"
Could not execute command %s (%s). Check the device extractor
"
%
(
cmd
,
arg
))
return
None
self
.
logger
.
warning
(
"
Retrying...
"
)
continue
break
if
i
==
2
:
logger
.
error
(
"
Could not execute command %s (%s). Check the device extractor
"
%
(
cmd
,
arg
))
return
None
return
cmdreturn
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment