Skip to content
Snippets Groups Projects

[ICATHALES-6] - Device do not start when driver not availible

Merged [ICATHALES-6] - Device do not start when driver not availible
software-control-system/prestations/forfait-agile-tsn/continuousao:ICATHALES-6 into main
1 open thread
Merged
BOISSYrequested to merge
software-control-system/prestations/forfait-agile-tsn/continuousao:ICATHALES-6 into main
1 open thread

Merge request reports

Merged by Arafat NOUREDDINEArafat NOUREDDINE Aug 11, 2022 (Aug 11, 2022 2:24pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Arafat NOUREDDINE
    Arafat NOUREDDINE @NOUREDDINE started a thread on the diff
    • src/ContinuousAO.cpp 100644 → 100755
    538 530 config.set_output_rate(frequency);
    539 531
    540 532 DEBUG_STREAM<<"ContinuousAO::init_device : init acq"<<std::endl;
    541 _ASL_TRY //_ACTION
    542 (
    543 ao->init(adl::DAQ2502, boardNum),
    544 "init",
    545 "ContinuousAO::init_device" //,
    546 // this->set_internal_state()
    547 );
    533 try{
    • Arafat NOUREDDINE
      Arafat NOUREDDINE @NOUREDDINE
      Maintainer

      _ASL_TRY de mémoire est une macro qui fait des try/ctach , pourquoi ajouter un try par dessus ?

    • BOISSY
      BOISSY @BOISSY
      Author Developer

      Parce que l'on ne souhaitait pas effectuer un call a une methode sans arguments. Nous souhaitions faire appelle a notre methode "on_fault", en lui passant la chaine de caractere voulue.

      Cela dit, le _ASL_TRY etait effectivement plus necessaire du coup, on l'a donc retiré

    • Please register or sign in to reply
  • BOISSY added 1 commit

    added 1 commit

    • 64a02762 - Correcting on_fault method name, and removing unnecessary _ASL_TRY

    Compare with previous version

  • Arafat NOUREDDINE approved this merge request

    approved this merge request

  • Arafat NOUREDDINE mentioned in commit be4b758a

    mentioned in commit be4b758a

  • Arafat NOUREDDINE merged

    merged

    • Please register or sign in to reply

    The place to be for your source code