From 725b1123d8cf1030e23c9c175c0e6ca93da46a12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Romain=20Bron=C3=A8s?= <romain.brones@synchrotron-soleil.fr> Date: Fri, 17 Mar 2023 11:08:09 +0100 Subject: [PATCH] fix:Fully remove Tready * Remove undriven logic in protocol decoder. --- hdl/combpm_protocol_electron.vhd | 9 +-------- hdl/top_combpm_electron.vhd | 2 -- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/hdl/combpm_protocol_electron.vhd b/hdl/combpm_protocol_electron.vhd index aed7621..c36c6ac 100644 --- a/hdl/combpm_protocol_electron.vhd +++ b/hdl/combpm_protocol_electron.vhd @@ -18,7 +18,6 @@ entity combpm_protocol_electron is -- AXIS interface m_axis_m2s : out t_bpmpacket_axis_m2s; - m_axis_s2m : in t_bpmpacket_axis_s2m; -- Status and control interface soft_reset : in std_logic; -- Reset all counters. @@ -260,14 +259,8 @@ begin -- AXIS TVALID m_axi_tvalid <= '1'; else - - -- Acknowledge transfer - if m_axis_s2m.tready = '1' then - m_axi_tvalid <= '0'; - end if; + m_axi_tvalid <= '0'; end if; - - end if; end process p_axis; diff --git a/hdl/top_combpm_electron.vhd b/hdl/top_combpm_electron.vhd index 4fd42cb..b8fabe4 100644 --- a/hdl/top_combpm_electron.vhd +++ b/hdl/top_combpm_electron.vhd @@ -95,7 +95,6 @@ architecture struct of top_combpm_electron is signal cdc_control_array_bpm : std_logic_vector(2 downto 0); -- CDC, clock bpm side signal m_axis_decoded_m2s : t_bpmpacket_axis_m2s; - signal m_axis_decoded_s2m : t_bpmpacket_axis_s2m; -- warning: TREADY is ignored ! begin @@ -237,7 +236,6 @@ begin gt_datarx => gt_datarx, m_axis_m2s => m_axis_decoded_m2s, - m_axis_s2m => m_axis_decoded_s2m, mc_time => mc_time, soft_reset => addrmap_w.PROTOCOL.SOFTRESET.data(0), -- GitLab